Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify host path in addFileSystemBind #4276

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Verify host path in addFileSystemBind #4276

merged 1 commit into from
Jun 30, 2020

Conversation

findepi
Copy link
Member

@findepi findepi commented Jun 30, 2020

d35f2b2 added verification for
withFileSystemBind. This covers addFileSystemBind.

@findepi
Verify host path in addFileSystemBind
09beef0 
d35f2b2 added verification for
`withFileSystemBind`. This covers `addFileSystemBind`.
@findepi findepi requested a review from kokosing June 30, 2020 10:59
@findepi
Copy link
Member Author

findepi commented Jun 30, 2020

Offered upstream in testcontainers/testcontainers-java#2955.

@findepi
Copy link
Member Author

findepi commented Jun 30, 2020

CI failed -- #3161

@findepi findepi merged commit adcccc5 into trinodb:master Jun 30, 2020
@findepi findepi deleted the findepi/master/verify-host-path-in-addfilesystembind-c43cef branch June 30, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokosing kokosing kokosing approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @kokosing