Support CTAS for Hive transactional tables #4516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Jul 21, 2020
| @@ -883,7 +891,9 @@ public void createTable(ConnectorSession session, ConnectorTableMetadata tableMe | |||
| // When metastore is configured with metastore.create.as.acid=true, it will also change Presto-created tables | |||
| // behind the scenes. In particular, this won't work with CTAS. | |||
| // TODO (https://github.com/prestosql/presto/issues/1956) convert this into normal table property | |||
| tableProperties.put(TRANSACTIONAL, "false"); | |||
|
|
|||
| boolean transactional = HiveTableProperties.isTransactional(tableMetadata.getProperties()).orElseGet(() -> false); | |||
| } | ||
| else { | ||
| if (bucketNumber.isPresent()) { | ||
| return computeBucketedFileName(Optional.of(queryId), bucketNumber.getAsInt()); |
There was a problem hiding this comment.
i know its preexisting, but how do we avoid collisions here?
@electrum
| UnsignedLong.fromLongBits(uuid.getMostSignificantBits()).toString()); | ||
| } | ||
| } | ||
| else { |
There was a problem hiding this comment.
Changed, though it kinda looks worse with long code blocks imo.
| if (bucketNumber.isPresent()) { | ||
| return computeBucketedFileName(Optional.empty(), bucketNumber.getAsInt()); | ||
| } | ||
| else { |
| if (queryId.isPresent()) { | ||
| return format("0%s_0_%s", paddedBucket, queryId.get()); | ||
| } | ||
| else { |
Comment on lines
559
to
560
| // For bucketed tables we drop query id from file names and just leave <bucketId>_0 | ||
| // For non bucketed tables we use 000000_<uuid_as_number> |
There was a problem hiding this comment.
It seems like bucketNumber.isPresent() is the more important condition than isTransactionalTable.
So I'd structure the code different, with bucket being the top if.
| UUID uuid = randomUUID(); | ||
| return format("0%s_%s%s", | ||
| paddedBucket, | ||
| UnsignedLong.fromLongBits(uuid.getLeastSignificantBits()).toString(), |
There was a problem hiding this comment.
Suggested change
| UnsignedLong.fromLongBits(uuid.getLeastSignificantBits()).toString(), | |
| Long.toUnsignedString(uuid.getLeastSignificantBits()), |
| else { | ||
| fileName = queryId + "_" + randomUUID(); | ||
| } | ||
| fileName = computeFileName(bucketNumber); |
| @@ -549,6 +549,37 @@ else if (insertExistingPartitionsBehavior == InsertExistingPartitionsBehavior.ER | |||
| hiveWriterStats); | |||
| } | |||
|
|
|||
| private String computeFileName(OptionalInt bucketNumber) | |||
There was a problem hiding this comment.
can we have this right above computeBucketedFileName?
| public void testCtasAcidTable(boolean isPartitioned, BucketingType bucketingType) | ||
| { | ||
| if (getHiveVersionMajor() < 3) { | ||
| throw new SkipException("Presto Hive transactional tables are supported with Hive version 3 or above"); |
There was a problem hiding this comment.
Presto Hive transactional -> Hive transactional
|
AC |
|
Rebased on new version of #2930 on master. |
|
Superseded by #4574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on https://github.com/prestosql/presto/pull/2930/files, so please just review top commit.