Support parameter in LIMIT clause #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Jul 22, 2020
| analysis.getParameters())); | ||
| } | ||
| catch (VerifyException e) { | ||
| throw semanticException(TYPE_MISMATCH, node, "Non constant parameter value for LIMIT: %s", providedValue); |
There was a problem hiding this comment.
TYPE_MISMATCH is not an appropriate code for this error. Let's go with INVALID_ARGUMENTS
| @Test | ||
| public void testLimitInvalidRowCount() | ||
| { | ||
| assertFails("SELECT * FROM t1 LIMIT 987654321098765432109876543210") |
There was a problem hiding this comment.
It doesn't throw PrestoException any more.
The row count used to be fetched as text and analysed in the StatementAnalyzer. After this change, a LongLiteral is instantiated in AstBuilder, and ParsingException is thrown.
Similarly, negative values now fail in Parser.
| @@ -164,8 +164,14 @@ queryNoWith: | |||
| queryTerm | |||
| (ORDER BY sortItem (',' sortItem)*)? | |||
| (OFFSET offset=INTEGER_VALUE (ROW | ROWS)?)? | |||
| ((LIMIT limit=(INTEGER_VALUE | ALL)) | (FETCH (FIRST | NEXT) (fetchFirst=INTEGER_VALUE)? (ROW | ROWS) (ONLY | WITH TIES)))? | |||
| ; | |||
| ((LIMIT limitRowCount) | (FETCH (FIRST | NEXT) (fetchFirst=INTEGER_VALUE)? (ROW | ROWS) (ONLY | WITH TIES)))? | |||
There was a problem hiding this comment.
We should do the same for FETCH FIRST and OFFSET, but this can be addressed in a separate PR
kasiafi
force-pushed
the
100LimitParameter
branch
3 times, most recently
from
2605ecb to
73131a8
Compare
Used to throw NullPointerException
kasiafi
force-pushed
the
100LimitParameter
branch
from
73131a8 to
6f0283d
Compare
mosabua
added
the
needs-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.