Apply DomainTranslator to STARTS_WITH function #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
force-pushed
the
domain_translation_starts_with
branch
from
1c99fb2 to
40f8f89
Compare
kokosing
approved these changes
Aug 3, 2020
sopel39
reviewed
Aug 3, 2020
| if (args.size() != 2) { | ||
| return Optional.empty(); | ||
| } | ||
| if (!(args.get(0) instanceof SymbolReference)) { |
There was a problem hiding this comment.
please extarct args.get(0) and args.get(1) as separate variables
presto-main/src/test/java/io/prestosql/sql/planner/TestDomainTranslator.java
Show resolved
Hide resolved
takezoe
force-pushed
the
domain_translation_starts_with
branch
from
40f8f89 to
aaddb47
Compare
sopel39
approved these changes
Aug 3, 2020
presto-main/src/test/java/io/prestosql/sql/planner/TestDomainTranslator.java
Show resolved
Hide resolved
| assertUnsupportedPredicate(startsWith(C_VARCHAR, stringLiteral(""))); | ||
|
|
||
| // non-ASCII | ||
| testSimpleComparison( |
There was a problem hiding this comment.
Could you add test for complement case?
sopel39
reviewed
Aug 3, 2020
| @@ -1582,6 +1582,39 @@ public void testLikePredicate() | |||
| assertUnsupportedPredicate(not(like(C_VARCHAR, stringLiteral("abc\\_def")))); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testStartsWithFunction() | |||
There was a problem hiding this comment.
Could you add a test for generic function call (that it's not supported)?
There was a problem hiding this comment.
Added testUnsupportedFunctions() which tests some unsupported functions.
takezoe
force-pushed
the
domain_translation_starts_with
branch
from
aaddb47 to
990129e
Compare
sopel39
approved these changes
Aug 4, 2020
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.