Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using shaded classes #4744

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Avoid using shaded classes #4744

merged 2 commits into from
Aug 17, 2020

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 7, 2020

No description provided.

@cla-bot cla-bot bot added the cla-signed label Aug 7, 2020
@findepi
Copy link
Member Author

findepi commented Aug 7, 2020

We could think about a checkstyle rule as well, but unfortunately some alluxio.shaded. classes are actually part of the library API.

electrum
electrum approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can at least add rules for the known bad ones.

@findepi
Copy link
Member Author

findepi commented Aug 8, 2020

We can at least add rules for the known bad ones.

airlift/airbase#234

@findepi findepi force-pushed the findepi/master/avoid-using-shaded-classes-ea2a95 branch from 89da6aa to 8d51296 Compare August 8, 2020 20:49
@findepi findepi force-pushed the findepi/master/avoid-using-shaded-classes-ea2a95 branch from 8d51296 to 0129d04 Compare August 17, 2020 15:54
@findepi findepi force-pushed the findepi/master/avoid-using-shaded-classes-ea2a95 branch from bb0efcc to 24641af Compare August 17, 2020 16:05
@findepi findepi force-pushed the findepi/master/avoid-using-shaded-classes-ea2a95 branch from 24641af to 559b8c9 Compare August 17, 2020 16:10
@findepi
Copy link
Member Author

findepi commented Aug 17, 2020

CI failed -- #4864

@findepi findepi merged commit 38ecc95 into trinodb:master Aug 17, 2020
@findepi findepi deleted the findepi/master/avoid-using-shaded-classes-ea2a95 branch August 17, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electrum electrum electrum approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @electrum