Allow INSERT null for SQL Server varbinary type #4846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Aug 15, 2020
...sqlserver/src/test/java/io/prestosql/plugin/sqlserver/TestSqlServerIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
...sqlserver/src/test/java/io/prestosql/plugin/sqlserver/TestSqlServerIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
...sqlserver/src/test/java/io/prestosql/plugin/sqlserver/TestSqlServerIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Aug 15, 2020
...sqlserver/src/test/java/io/prestosql/plugin/sqlserver/TestSqlServerIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
sqlserver-varbinary
branch
from
09a28bc to
9fe0175
Compare
ebyhr
force-pushed
the
sqlserver-varbinary
branch
from
9fe0175 to
034fd85
Compare
findepi
approved these changes
Aug 25, 2020
presto-sqlserver/src/test/java/io/prestosql/plugin/sqlserver/TestSqlServerTypeMapping.java
Outdated
Show resolved
Hide resolved
presto-sqlserver/src/test/java/io/prestosql/plugin/sqlserver/TestSqlServerTypeMapping.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
sqlserver-varbinary
branch
from
034fd85 to
c25f0a1
Compare
ebyhr
force-pushed
the
sqlserver-varbinary
branch
from
c25f0a1 to
1edb1fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4795
The original
statement.setObject(index, null)in WriteFunction causes conversion error.