Enable table properties for JDBC connectors #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
approved these changes
Aug 28, 2020
| @@ -85,4 +85,14 @@ public static void bindProcedure(Binder binder, Class<? extends Provider<? exten | |||
| { | |||
| procedureBinder(binder).addBinding().toProvider(type).in(Scopes.SINGLETON); | |||
| } | |||
|
|
|||
| public static Multibinder<TablePropertiesProvider> tablePropertiesProviderMultiBinder(Binder binder) | |||
There was a problem hiding this comment.
Remove Multi from the name for consistency with bindSessionPropertiesProvider
There was a problem hiding this comment.
How about tablePropertiesBinder?
There was a problem hiding this comment.
Renamed it as bindTablePropertiesProvider
There was a problem hiding this comment.
We have JdbcModule#sessionPropertiesProviderBinder, so tablePropertiesProviderBinder would be consistent.
kokosing
reviewed
Aug 28, 2020
| @@ -85,4 +85,14 @@ public static void bindProcedure(Binder binder, Class<? extends Provider<? exten | |||
| { | |||
| procedureBinder(binder).addBinding().toProvider(type).in(Scopes.SINGLETON); | |||
| } | |||
|
|
|||
| public static Multibinder<TablePropertiesProvider> tablePropertiesProviderMultiBinder(Binder binder) | |||
There was a problem hiding this comment.
How about tablePropertiesBinder?
| @@ -13,6 +13,8 @@ | |||
| */ | |||
There was a problem hiding this comment.
Minor cleanup in Phoenix connector
What kind of cleanup? Commit message is ambiguous. Can you please be more specific.
There was a problem hiding this comment.
Now we pass the table properties via JdbcClient (PhoenixClient)
Praveen2112
force-pushed
the
phoenix_table_properties
branch
3 times, most recently
from
98c8e83 to
faba41c
Compare
kokosing
approved these changes
Sep 3, 2020
Praveen2112
force-pushed
the
phoenix_table_properties
branch
from
faba41c to
53f8378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to session property we can allow table properties to be configured when creating tables for JDBC based connector