Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark testWrittenStats test as @Flaky #5405

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 4, 2020

Relates to #5172

@findepi findepi requested a review from sopel39 October 4, 2020 13:03
@cla-bot cla-bot bot added the cla-signed label Oct 4, 2020
@findepi
Copy link
Member Author

findepi commented Oct 4, 2020

CI failed -- #4936

@@ -1254,6 +1255,7 @@ public void testViewFunctionAccessControl()
}

@Test
@Flaky(issue = "https://github.com/prestosql/presto/issues/5172", match = "AssertionError: expected \\[1\\] but found \\[0\\]")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any of the getQueryStats() condition can fail

@findepi findepi force-pushed the findepi/master/mark-testwrittenstats-test-as-flaky-6e4b99 branch from 7e40b5d to 646d51e Compare October 5, 2020 10:40
@findepi
Copy link
Member Author

findepi commented Oct 5, 2020

AC

@findepi findepi merged commit 8b11b39 into trinodb:master Oct 5, 2020
@findepi findepi deleted the findepi/master/mark-testwrittenstats-test-as-flaky-6e4b99 branch October 5, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants