Do not swallow interrupted exception #5421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Possibly fixes #5422 |
wendigo
approved these changes
Oct 6, 2020
kokosing
force-pushed
the
origin/master/254_stop_with_interrupt
branch
from
3a3aea6 to
b22472f
Compare
|
@wendigo Added one more commit. |
findepi
reviewed
Oct 6, 2020
| @@ -52,6 +52,7 @@ | |||
| import static io.airlift.concurrent.Threads.daemonThreadsNamed; | |||
| import static io.airlift.units.DataSize.ofBytes; | |||
| import static java.lang.String.format; | |||
| import static java.lang.Thread.currentThread; | |||
There was a problem hiding this comment.
This is typically not static imported
There was a problem hiding this comment.
Thread.currentThread() looks like ImmutableList.toImmutableList()
There was a problem hiding this comment.
I applied your comment. I see that this is common. I will leave it for another time.
There was a problem hiding this comment.
Thread.currentThread()looks likeImmutableList.toImmutableList()
the similarity is deceptive
Catching Exception is very broad and error prone. This refactor changes that to catch only exceptions that are possibly thrown.
kokosing
force-pushed
the
origin/master/254_stop_with_interrupt
branch
from
b22472f to
9be7c68
Compare
|
Failed with: #5427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not swallow interrupted exception