Add Yugabyte connector

[tedyu]

This creates presto-yugabyte module

Part of #5352

• Add tests
• Add yugabyte.rst to presto-docs/src/main/sphinx/connector
• Update presto-docs/src/main/sphinx/connector.rst

[findepi]

@tedyu Would it be possible to add a TestYugabyteIntegrationSmokeTest similar to TestCassandraIntegrationSmokeTest?
You will need

• TestingYugabyteServer
  • perhaps this can use org.testcontainers.containers.GenericContainer with https://hub.docker.com/r/yugabytedb/yugabyte
• YugabyteQueryRunner that takes the TestingYugabyteServer and produces DistributedQueryRunner
  • see CassandraQueryRunner for example

[tedyu]

When building the module with dependency on 3.2.0-yb-19-1 of yugabyte-driver, I got the following warning:

[WARNING] Unused declared dependencies found:
[WARNING]    io.prestosql.yugabyte:yugabyte-driver:jar:3.2.0-yb-19-1:compile

[findepi]

You should be able to use runtime scope for this.

[findepi]

@tedyu can you make sure the build is green?

[tedyu]

@findepi
The build is green.

Please take another look.

[tedyu]

@findepi
Is there anything else I should do ?

[ebyhr]

@tedyu Could you add tests as suggested in #5708 (comment)?

[tedyu]

I have other priorities at day job.
It seems the integration test would need non-trivial effort.

Can we do that later ?

[tedyu]

ping @findepi to see if this can go in.

thanks

[tedyu]

@findepi
Test dependencies have been removed.

[findepi]

@tedyu thanks for removing some test dependencies. Can you remove those remaining ones as well please?

[tedyu]

@findepi
Remaining ones have been removed.

[findepi]

@ebyhr PTAL

[ebyhr]

@tedyu I'm testing this PR locally, but it throws NPE during servrer initialization. Is this PR working in your environment?

connector.name=yugabyte
cassandra.contact-points=yugabyte
cassandra.native-protocol-port=9042

1) Error in custom provider, java.lang.NullPointerException
  at io.prestosql.plugin.cassandra.CassandraClientModule.createCassandraSession(CassandraClientModule.java:92)
  while locating io.prestosql.plugin.cassandra.CassandraSession
Caused by: java.lang.NullPointerException
	at com.datastax.driver.core.Cluster$Manager.<init>(Cluster.java:1408)
	at com.datastax.driver.core.Cluster$Manager.<init>(Cluster.java:1355)
	at com.datastax.driver.core.Cluster.<init>(Cluster.java:125)
	at com.datastax.driver.core.Cluster.<init>(Cluster.java:98)
	at com.datastax.driver.core.DelegatingCluster.<init>(DelegatingCluster.java:45)
	at io.prestosql.plugin.cassandra.ReopeningCluster.<init>(ReopeningCluster.java:44)

.

[findepi]

@ebyhr thanks for catching this

this means it's not so simple. we should add

1. a test similar to TestPostgreSqlPlugin (for both Yugabyte and Cassandra ideally)
2. a test similar to TestCassandraIntegrationSmokeTest
3. a product test, see SinglenodeCassandra for a starting point

[tedyu]

With upcoming Holidays, response may be slow.

[ebyhr]

@tedyu Are you still working on this? Do you mind if someone take over this?

[tedyu]

Taking over for creating presto-yugabyte module ?

Sure.

[ebyhr]

I'm trying the Yugabyte driver locally and realized a new schema or table still doesn't appear when listing in Trino. It seems the root cause is Session is reused in CassandraSession class by memoize(cluster::connect) and also ReopeningCluster needs fix.

I would check if we can just fix in Cassandra connector.

[ebyhr]

About bootstrap issue #5708 (comment), DelegatingCluster passes null as Configuration at
DelegatingCluster.java#L49 and it causes NPE at Cluster.java#L1620

yugabyte/cassandra-java-driver#8

[ebyhr]

As far as I know, YCQL and YSQL are independent (= tables created in YCQL doesn't appear in YSQL). We may want to avoid just yugabyte as a connector name and rename to yugabyte-cassandra, yugabyte-cql or something.

[mosabua]

👋 @tedyu @ebyhr - this PR has become inactive. If you're still interested in working on it, please let us know.

We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.