Mark partitioning TestCsv tests as @Flaky #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
commented
Nov 7, 2020
kokosing
approved these changes
Nov 7, 2020
| @@ -62,12 +63,14 @@ private void testInsertIntoCsvTable(String tableName, String additionalTableProp | |||
| } | |||
|
|
|||
| @Test(groups = STORAGE_FORMATS) | |||
| @Flaky(issue = "https://github.com/prestosql/presto/issues/4936", match = "Error committing write to Hive(?s.*)could only be replicated to 0 nodes instead of minReplication") | |||
There was a problem hiding this comment.
pre-existing. Also, I am not convinced. I'd rather see the problem fixed rather than make it easier to update. And in the worst case, updating multiple occurrences is not a big deal.
findepi
deleted the
findepi/mark-partitioning-testcsv-tests-as-flaky-8db05f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #4936