Fix retries for TestIcebergCreateTable #5971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokosing
approved these changes
Nov 16, 2020
| @BeforeTestWithContext | ||
| public void setUp() | ||
| { | ||
| onPresto().executeQuery("CREATE SCHEMA iceberg.iceberg"); |
There was a problem hiding this comment.
pre-existing and i'd want to consider this out of scope for this PR. can i?
| } | ||
|
|
||
| @AfterTestWithContext | ||
| public void cleanUp() |
There was a problem hiding this comment.
Let's remove it. One might hit some issues when running tests in parallel some day...
There was a problem hiding this comment.
pre-existing and i'd want to consider this out of scope for this PR. can i?
| @@ -13,6 +13,8 @@ | |||
| */ | |||
There was a problem hiding this comment.
nit: I would change commit title to Make TestIcebergCreateTable retriable
There was a problem hiding this comment.
The only reason im doing this is because i added @Flaky and it didn't work. So my point is -- fix the retries.
if there was no @Flaky, i wouldn't do the change.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4864