Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vertica connector #6134

Closed
wants to merge 2 commits into from
Closed

Add Vertica connector #6134

wants to merge 2 commits into from

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Nov 29, 2020 •
edited
Loading

Disallowed dropping column because there are some restrictions as follows. I suppose we can support it later.
https://www.vertica.com/docs/10.0.x/HTML/Content/Authoring/AdministratorsGuide/Tables/ModifyTableDefinition/DroppingATableColumn.htm

Vertica SQL reference manual is here.
https://www.vertica.com/docs/10.0.x/HTML/Content/Authoring/SQLReferenceManual/SQLReferenceManual.htm

  • Check Vertica JDBC driver license
  • Fix flaky initialization of TestingVerticaServer

@ebyhr ebyhr added the enhancement New feature or request label Nov 29, 2020
@cla-bot cla-bot bot added the cla-signed label Nov 29, 2020
@ebyhr ebyhr force-pushed the vertica_connector branch 3 times, most recently from a692372 to 532508f Compare November 29, 2020 04:28
@tooptoop4 tooptoop4 mentioned this pull request Nov 29, 2020
Closed
findepi
findepi reviewed Nov 29, 2020
View reviewed changes
presto-vertica/pom.xml Outdated Show resolved Hide resolved
@ebyhr ebyhr force-pushed the vertica_connector branch 2 times, most recently from ab48b43 to af89058 Compare December 3, 2020 23:57
kokosing
kokosing reviewed Dec 4, 2020
View reviewed changes
Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for type mapping, especially for date type.

presto-vertica/pom.xml Outdated Show resolved Hide resolved
presto-vertica/src/test/java/io/prestosql/plugin/vertica/TestVerticaDistributedQueries.java Outdated Show resolved Hide resolved
presto-vertica/src/test/java/io/prestosql/plugin/vertica/TestVerticaDistributedQueries.java Outdated Show resolved Hide resolved
@ebyhr ebyhr force-pushed the vertica_connector branch 4 times, most recently from 3a1df2f to 6fd1846 Compare December 6, 2020 06:13
findepi
findepi reviewed Dec 7, 2020
View reviewed changes
presto-vertica/pom.xml Outdated Show resolved Hide resolved
presto-vertica/src/main/java/io/prestosql/plugin/vertica/VerticaClient.java Outdated Show resolved Hide resolved
presto-vertica/src/main/java/io/prestosql/plugin/vertica/VerticaClient.java Outdated Show resolved Hide resolved
presto-vertica/src/test/java/io/prestosql/plugin/vertica/TestVerticaIntegrationSmokeTest.java Outdated Show resolved Hide resolved
presto-vertica/src/test/java/io/prestosql/plugin/vertica/TestVerticaIntegrationSmokeTest.java Outdated Show resolved Hide resolved
presto-vertica/src/test/java/io/prestosql/plugin/vertica/TestVerticaIntegrationSmokeTest.java Outdated Show resolved Hide resolved
presto-vertica/src/test/java/io/prestosql/plugin/vertica/VerticaQueryRunner.java Outdated Show resolved Hide resolved
presto-vertica/src/test/java/io/prestosql/plugin/vertica/VerticaQueryRunner.java Outdated Show resolved Hide resolved
@ebyhr ebyhr force-pushed the vertica_connector branch 2 times, most recently from be0a7bc to eed2c82 Compare December 22, 2020 07:07
@ebyhr ebyhr force-pushed the vertica_connector branch 3 times, most recently from 6804cf2 to 6cac9a8 Compare January 4, 2021 06:47
@ebyhr ebyhr force-pushed the vertica_connector branch from 6cac9a8 to f2bf0e8 Compare January 18, 2021 14:45
@findepi findepi mentioned this pull request Jan 20, 2021
Closed
@ebyhr ebyhr force-pushed the vertica_connector branch from f2bf0e8 to 3c4e813 Compare February 12, 2021 13:30
@ebyhr ebyhr force-pushed the vertica_connector branch from 3c4e813 to ad1cae9 Compare March 2, 2021 10:39
@findepi
Copy link
Member

findepi commented Mar 2, 2021

Would be great to have #6134 (comment) resolved, as i would like to start the review here.

@ebyhr ebyhr force-pushed the vertica_connector branch from ad1cae9 to 9a657eb Compare March 11, 2021 12:42
@ebyhr ebyhr force-pushed the vertica_connector branch from 9a657eb to 5b837b4 Compare April 10, 2021 11:18
@ebyhr ebyhr closed this May 11, 2022
@ebyhr ebyhr deleted the vertica_connector branch May 11, 2022 16:15
@ebyhr ebyhr restored the vertica_connector branch November 7, 2023 08:34
@ebyhr ebyhr reopened this Nov 7, 2023
@ebyhr ebyhr force-pushed the vertica_connector branch from 9053a0a to 9bdd6e6 Compare December 12, 2023 00:40
@ebyhr ebyhr marked this pull request as ready for review December 15, 2023 07:14
@ebyhr ebyhr force-pushed the vertica_connector branch 2 times, most recently from aa69c9f to b4af8f7 Compare January 5, 2024 14:27
@mosabua
Copy link
Member

mosabua commented Jan 15, 2024

I assume this PR is still in progress @ebyhr

@ebyhr ebyhr force-pushed the vertica_connector branch from b4af8f7 to a202920 Compare March 4, 2024 00:35
@ebyhr ebyhr force-pushed the vertica_connector branch from a202920 to 3606869 Compare March 8, 2024 05:00
@ebyhr ebyhr force-pushed the vertica_connector branch from 3606869 to 474cdfa Compare March 25, 2024 00:32
@bentzimortaboola
Copy link

@ebyhr @mosabua
any ETA for merging this PR?

@mosabua mosabua added the stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. label Sep 3, 2024
@ebyhr ebyhr closed this Sep 4, 2024
@ebyhr ebyhr deleted the vertica_connector branch September 4, 2024 03:00
@ebyhr ebyhr restored the vertica_connector branch September 11, 2024 22:45
@ebyhr ebyhr reopened this Sep 11, 2024
@pandatrooper
Copy link

Hey @ebyhr, are we still planning to merge this PR ?

@bentzimortaboola
Copy link

bentzimortaboola commented Sep 23, 2024 •
edited
Loading

what the status here? we are waiting too long for it

@mosabua
Copy link
Member

mosabua commented Sep 23, 2024

Yes .. we are planning to get a Vertica connector added soon. We are just a bit strapped for people to work on it.

@legiondean
Copy link

@mosabua any chance to merge this pr soon?

@ebyhr
Copy link
Member Author

ebyhr commented Oct 28, 2024

We will continue at #23948

@ebyhr ebyhr closed this Oct 28, 2024
@ebyhr ebyhr deleted the vertica_connector branch October 28, 2024 22:52
@mosabua mosabua mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar left review comments

@kokosing kokosing kokosing left review comments

@PChou PChou PChou left review comments

@mosabua mosabua mosabua left review comments

@findepi findepi findepi left review comments

@martint martint martint left review comments

Assignees
No one assigned
Labels
cla-signed docs enhancement New feature or request stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.