Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example reference in resource groups doc #6568

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Fix example reference in resource groups doc #6568

merged 1 commit into from
Jan 14, 2021

Conversation

mfzarko
Copy link
Member

@mfzarko mfzarko commented Jan 11, 2021

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 11, 2021
@mfzarko mfzarko requested a review from mosabua January 11, 2021 20:04
mosabua
mosabua approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and thanks for the fix.

@mosabua mosabua added the docs label Jan 11, 2021
@mosabua mosabua requested a review from electrum January 11, 2021 20:20
phd3
phd3 reviewed Jan 11, 2021
View reviewed changes
Copy link
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. The same bullet seems to have some other outdated references too, can you please fix them too for consistency?

docs/src/main/sphinx/admin/resource-groups.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/admin/resource-groups.rst Outdated Show resolved Hide resolved
docs/src/main/sphinx/admin/resource-groups.rst Outdated Show resolved Hide resolved
@mfzarko
Copy link
Member Author

mfzarko commented Jan 12, 2021 •
edited
Loading

Updated per @phd3 suggestions. Thank you!

@findepi findepi requested a review from phd3 January 13, 2021 22:59
@phd3
Copy link
Member

phd3 commented Jan 13, 2021

Unrelated failure, looks similar to #4936

io.trino.tests.hive.TestHiveStorageFormats.testInsertIntoPartitionedTable [StorageFormat{name=AVRO, properties={}, sessionProperties={}}] (Groups: storage_formats)

@phd3 phd3 merged commit 1b4dfe0 into trinodb:master Jan 14, 2021
@phd3
Copy link
Member

phd3 commented Jan 14, 2021

Merged after a minor fixup, thanks for improving the documentation @mfzarko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

@electrum electrum Awaiting requested review from electrum

@phd3 phd3 Awaiting requested review from phd3

Assignees
No one assigned
Labels
cla-signed docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfzarko @phd3 @mosabua @electrum