Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make open writers limit configurable in iceberg connector #6684

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

akshayrai
Copy link
Contributor

Addresses #6650

@cla-bot
Copy link

cla-bot bot commented Jan 22, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

Copy link
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, some minor comments.

nit: I'd rename the commit message to "Make open writers limit configurable in iceberg connector"

@cla-bot
Copy link

cla-bot bot commented Jan 25, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@akshayrai akshayrai changed the title Make Iceberg maxOpenWriters configurable Make open writers limit configurable in iceberg connector Jan 25, 2021
Copy link
Member

@phd3 phd3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! can you please squash the fixup commit and update message?

@cla-bot cla-bot bot added the cla-signed label Feb 4, 2021
@phd3 phd3 merged commit 772dd7f into trinodb:master Feb 5, 2021
@phd3 phd3 added this to the 352 milestone Feb 5, 2021
@phd3 phd3 mentioned this pull request Feb 5, 2021
10 tasks
@phd3
Copy link
Member

phd3 commented Feb 5, 2021

Merged, thanks @akshayrai !

@akshayrai akshayrai deleted the iceConf branch February 5, 2021 00:43
v-jizhang added a commit to v-jizhang/presto that referenced this pull request May 18, 2022
Cherry-pick of Trino trinodb/trino#6684

Co-authored-by: Akshay Rai <akrai@linkedin.com>
NikhilCollooru pushed a commit to prestodb/presto that referenced this pull request May 19, 2022
Cherry-pick of Trino trinodb/trino#6684

Co-authored-by: Akshay Rai <akrai@linkedin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants