Use a temporary table to verify if deletes are supported #8487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow-up to #8482. |
wendigo
approved these changes
Jul 8, 2021
losipiuk
reviewed
Jul 8, 2021
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
Show resolved
Hide resolved
kokosing
approved these changes
Jul 8, 2021
Not all connector tests run within containers so any operation that deletes data from the TPCH tables can change state of the testing infrastructure leading to hard to diagnose failures. So we create temporary tables to verify if deletes are supported or not.
hashhar
force-pushed
the
hashhar/delete-tests-isolation
branch
from
7bfcb0d to
e133dfb
Compare
lukasz-walkiewicz
approved these changes
Jul 8, 2021
|
CI hit #4568. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all connector tests run within containers so any operation that
deletes data from the TPCH tables can change state of the testing
infrastructure leading to hard to diagnose failures.
So we create temporary tables to verify if deletes are supported or not.