Bind container ports to host ports by default in product tests #8739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/port-binding-options
branch
2 times, most recently
from
d73343c to
c573d85
Compare
findepi
approved these changes
Aug 2, 2021
...uct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/EnvironmentOptions.java
Outdated
Show resolved
Hide resolved
...uct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/EnvironmentOptions.java
Show resolved
Hide resolved
...duct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/EnvironmentModule.java
Show resolved
Hide resolved
|
@wendigo see CI outcome |
wendigo
force-pushed
the
serafin/port-binding-options
branch
from
c573d85 to
77cc646
Compare
|
@wendigo please push an |
|
@findepi here you go |
kokosing
approved these changes
Aug 2, 2021
| import static picocli.CommandLine.Option; | ||
|
|
||
| public final class EnvironmentOptions | ||
| { | ||
| private static final String DEFAULT_VALUE = "(default: ${DEFAULT-VALUE})"; | ||
| public static final String BIND_ON_HOST = "on"; | ||
| public static final String DO_NOT_BIND = "off"; |
|
@findepi done |
This was referenced Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.