Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement renameSchema for JDBC based connectors #8939

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Implement renameSchema for JDBC based connectors #8939

merged 3 commits into from
Jan 13, 2022

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Aug 21, 2021

No description provided.

@hashhar hashhar added the WIP label Aug 21, 2021
@cla-bot cla-bot bot added the cla-signed label Aug 21, 2021
@jhlodin jhlodin mentioned this pull request Aug 23, 2021
Closed
@hashhar
Make SUPPORTS_RENAME_SCHEMA default to SUPPORTS_CREATE_SCHEMA
08a9452 
If a connector doesn't support creating schemas it's not possible to
test if it supports renaming schemas. So to ensure test results aren't
misleading enforce that connectors that don't support schema creation
assume that schema rename isn't supported. The assumption is explicitly
validated so where needed it can be overridden by the connector.
@hashhar hashhar force-pushed the hashhar/jdbc-rename-schema branch from dc77281 to 08a9452 Compare January 11, 2022 08:47
@hashhar hashhar marked this pull request as ready for review January 11, 2022 11:31
@hashhar hashhar requested a review from ebyhr January 11, 2022 11:32
@hashhar hashhar removed the WIP label Jan 11, 2022
ebyhr
ebyhr approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run all tests for MemSQL just in case. Looks fine as far as I confirmed though.

I think "SQL support" in redshift.rst needs update.

plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java Show resolved Hide resolved
This was referenced Jan 12, 2022
Closed
Closed
@hashhar
Copy link
Member Author

hashhar commented Jan 12, 2022

@ebyhr Pushed a commit with updated docs and a fixup. PTAL.

@hashhar hashhar added docs and removed docs labels Jan 12, 2022
@hashhar hashhar requested a review from jhlodin January 12, 2022 09:51
@hashhar
Copy link
Member Author

hashhar commented Jan 12, 2022

Squashing the fixup.

@hashhar hashhar force-pushed the hashhar/jdbc-rename-schema branch from c95623d to 299ebb9 Compare January 12, 2022 13:53
jhlodin
jhlodin approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hashhar hashhar merged commit f9de866 into trinodb:master Jan 13, 2022
@hashhar hashhar deleted the hashhar/jdbc-rename-schema branch January 13, 2022 06:37
@github-actions github-actions bot added this to the 369 milestone Jan 13, 2022
@hashhar hashhar mentioned this pull request Jan 13, 2022
Closed
@mosabua mosabua mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi left review comments

@ebyhr ebyhr ebyhr approved these changes

@jhlodin jhlodin jhlodin approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
369
Development

Successfully merging this pull request may close these issues.
4 participants
@hashhar @findepi @jhlodin @ebyhr