Remove usage of @test with exceptions in plugin tests #9722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjo2144
reviewed
Nov 4, 2021
plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestTrinoS3FileSystem.java
Outdated
Show resolved
Hide resolved
alexjo2144
reviewed
Nov 4, 2021
plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestTrinoS3FileSystem.java
Outdated
Show resolved
Hide resolved
Damans227
force-pushed
the
damans227/issue-6974-15
branch
from
c78cae3 to
1f2099e
Compare
alexjo2144
reviewed
Jan 12, 2022
plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestTrinoS3FileSystem.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestTrinoS3FileSystem.java
Outdated
Show resolved
Hide resolved
Damans227
force-pushed
the
damans227/issue-6974-15
branch
from
1f2099e to
193a368
Compare
ebyhr
reviewed
Jan 15, 2022
plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestTrinoS3FileSystem.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestTrinoS3FileSystem.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Yuya Ebihara <ebyhry@gmail.com> Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
Damans227
force-pushed
the
damans227/issue-6974-15
branch
from
c58c37e to
6e4c253
Compare
ebyhr
approved these changes
Jan 17, 2022
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to
@Test(expectedExceptions...)cleanup issue #6974