Guard Hive's OPTIMIZE table procedure with session property #9761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Oct 25, 2021
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
OPTIMIZE procedure is disabled by default; even though code is written in a way to avoid data loss, calling procedure is inherently unsafe due to non transactional nature of committing changes done to Hive table. If Trino looses connectivity to HDFS cluster while deleting post-optimize data files duplicate rows will be left in table and manual cleanup from user will be required.
losipiuk
force-pushed
the
lo/guard-hive-optimize
branch
from
d791773 to
2568c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPTIMIZE procedure is disabled by default; even
though code is written in a way to avoid data loss, calling procedure
is inherently unsafe due to non transactional nature of
committing changes done to Hive table. If Trino looses connectivity to
HDFS cluster while deleting post-optimize data files duplicate rows will be
left in table and manual cleanup from user will be required.