Aggregation and window refactor #9837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
aggregation-window-refactor
branch
2 times, most recently
from
3e3ce8e to
604a361
Compare
|
Does this require benchmarks to be run? |
dain
force-pushed
the
aggregation-window-refactor
branch
from
604a361 to
245f90c
Compare
It would be great if you could do that. It shouldn't affect anything, but you never know. |
|
What APIs are changed by this PR? |
There are no SPI changes. There are quite a few changes to the internal function APIs, especially around aggregations and window functions |
dain
force-pushed
the
aggregation-window-refactor
branch
2 times, most recently
from
5a4b94b to
5d91db2
Compare
electrum
reviewed
Dec 4, 2021
|
Typo "AggergationMetadata" in commit title |
|
Typo "aggergation" in commit titles |
|
Looks good through commit "Add deterministic to ResolvedFunction" |
dain
force-pushed
the
aggregation-window-refactor
branch
from
5d91db2 to
08c5d13
Compare
electrum
approved these changes
Dec 14, 2021
...rino-main/src/main/java/io/trino/operator/aggregation/AbstractMinMaxAggregationFunction.java
Outdated
Show resolved
Hide resolved
.../trino-main/src/main/java/io/trino/operator/aggregation/GenericAccumulatorFactoryBinder.java
Outdated
Show resolved
Hide resolved
.../trino-main/src/main/java/io/trino/operator/aggregation/GenericAccumulatorFactoryBinder.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/function/AccumulatorStateFactory.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/TestAnnotationEngineForAggregates.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/window/pattern/ProjectingPagesWindowIndex.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/aggregation/TestingAggregationFunction.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/aggregation/CompiledAccumulatorFactory.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/window/RegularWindowPartition.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/aggregation/AccumulatorCompiler.java
Outdated
Show resolved
Hide resolved
Remove unnecessary methods from AccumulatorFactory Simplify aggregation binding by using layering Assume argument ordering in accumulator compiler Add AggregatorFactory to simplify usage in operators
Combine method is only allowed for decomposable aggregations
dain
force-pushed
the
aggregation-window-refactor
branch
from
08c5d13 to
9aa40b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.