Handle Iceberg files with missing Field IDs #9959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjo2144
force-pushed
the
iceberg/missing-field-ids
branch
2 times, most recently
from
84d52a5 to
1dc6a09
Compare
alexjo2144
commented
Nov 16, 2021
alexjo2144
force-pushed
the
iceberg/missing-field-ids
branch
from
1dc6a09 to
9ab109f
Compare
phd3
reviewed
Nov 18, 2021
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java
Show resolved
Hide resolved
phd3
approved these changes
Nov 29, 2021
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
| .forEach(column -> columnsById.put(getIcebergFieldId(column), column)); | ||
| .forEach(column -> { | ||
| String fieldId = (column.getAttributes().get(ORC_ICEBERG_ID_KEY)); | ||
| if (fieldId != null) { |
There was a problem hiding this comment.
could you explain the motivation for this? Shouldn't setMissingFieldIds throw for the null case before this?
There was a problem hiding this comment.
This can happen if the column does not have an id and the default name mapping is not present. @findepi suggested maybe we should fail in the case rather than having the column values be null #9843 (comment)
There was a problem hiding this comment.
I'm okay with returning null here, similar to Spark.
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java
Outdated
Show resolved
Hide resolved
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java
Outdated
Show resolved
Hide resolved
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java
Show resolved
Hide resolved
alexjo2144
force-pushed
the
iceberg/missing-field-ids
branch
from
9ab109f to
b95d365
Compare
|
Rebased and comments addressed, thanks for the review @phd3 |
alexjo2144
force-pushed
the
iceberg/missing-field-ids
branch
from
b95d365 to
d1062c6
Compare
phd3
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
@alexjo2144 LGTM, can you please squash? will merge if there're no other comments.
alexjo2144
force-pushed
the
iceberg/missing-field-ids
branch
from
d1062c6 to
9d6fb5e
Compare
|
Squashed and rebased for merge conflicts. Thanks @phd3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of the Dereference Pushdown PR: #8129Last commit is new.In progress PR for documenting the Iceberg NameMapping JSON: apache/iceberg#3556
more discussion on #9843