Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various code clean ups. #11901

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Various code clean ups. #11901

merged 2 commits into from
Aug 22, 2023

Conversation

asvitkine
Copy link
Contributor

Change Summary & Additional Notes

No functional changes.

Clean ups:

  • Rewrap some comments that were poorly wrapped due to past code reformatting.
  • Use GridBagConstraintsBuilder in BattleCalculatorPanel to make the code much more concise
  • Switch some countMatches() calls to noneMatch() and anyMatch().
  • Remove some unnecessary logic prior to calling getMaxUnitsToBePlacedFrom(), since getMaxUnitsToBePlacedFrom() does that logic already.

Release Note

@asvitkine asvitkine merged commit 4ad1583 into triplea-game:master Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant