Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update map snapshot labels (#1423) #1450

Conversation

ssoloff
Copy link
Member

@ssoloff ssoloff commented Jan 11, 2017

This change updates all remaining user-facing text that uses "screenshot" to instead use "map snapshot", as described in #1423.

After PR #1419 was merged, I only found a single occurrence that needed to be replaced: the command label for exporting a map snapshot in the Game History panel context menu. The shell command I ran from the repo root to search for possible occurrences follows:

$ find . -not \( -path ./.git -prune -o -path ./.gradle -prune -o -path ./bin -prune -o -path ./build -prune \) -type f | xargs grep -i screenshot

A screenshot of the single UI change is attached.

Note that there is an additional commit in this PR for an annotation that should have been added as part of #1419. Please advise if you'd like that moved to a separate PR or removed completely.

@ron-murhammer ron-murhammer merged commit a7b434b into triplea-game:master Jan 11, 2017
@ssoloff ssoloff deleted the issue-1423-update-map-snapshot-labels branch January 18, 2017 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants