Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #2080 #2544

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Conversation

ssoloff
Copy link
Member

@ssoloff ssoloff commented Oct 26, 2017

This PR reverts #2080 per #2529.

Users have reported a 2x degradation in the performance of the Battle
Calculator since build 3635.  Approximately 75% of that degradation was
traced to triplea-game#2080.
@codecov-io
Copy link

Codecov Report

Merging #2544 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2544      +/-   ##
============================================
- Coverage     20.37%   20.35%   -0.02%     
+ Complexity     5809     5804       -5     
============================================
  Files           831      831              
  Lines         73631    73617      -14     
  Branches      12400    12396       -4     
============================================
- Hits          14999    14982      -17     
- Misses        56578    56583       +5     
+ Partials       2054     2052       -2
Impacted Files Coverage Δ Complexity Δ
...mes/strategy/triplea/delegate/MustFightBattle.java 62.24% <ø> (-0.16%) 338 <0> (-3)
...trategy/triplea/delegate/UnitBattleComparator.java 31.31% <0%> (-4.05%) 21% <0%> (-1%)
...tegy/triplea/oddsCalculator/ta/OddsCalculator.java 43.75% <0%> (-0.32%) 13% <0%> (ø)
...java/games/strategy/triplea/delegate/DiceRoll.java 54.11% <0%> (-0.17%) 100% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61219cc...65adaaf. Read the comment docs.

@ron-murhammer ron-murhammer merged commit 714c72f into triplea-game:master Oct 26, 2017
@ssoloff ssoloff deleted the issue-2529-revert-2080 branch October 27, 2017 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants