Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment documenting why 'attach' is re-spelled to 'attatch' #7661

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

DanVanAtta
Copy link
Member

1.8 maps and previous named attachment as 'attatchment'

Testing

Screens Shots

Additional Notes to Reviewer

Release Note

1.8 maps and previous named attachment as 'attatchment'
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #7661 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7661   +/-   ##
=========================================
  Coverage     24.43%   24.43%           
- Complexity     7150     7152    +2     
=========================================
  Files          1218     1218           
  Lines         79070    79070           
  Branches      11325    11325           
=========================================
+ Hits          19318    19320    +2     
+ Misses        57576    57575    -1     
+ Partials       2176     2175    -1     
Impacted Files Coverage Δ Complexity Δ
...s/strategy/engine/data/ChangeAttachmentChange.java 74.28% <ø> (ø) 5.00 <0.00> (ø)
.../games/strategy/engine/data/DefaultAttachment.java 95.74% <ø> (ø) 26.00 <0.00> (ø)
...va/games/strategy/engine/data/NamedAttachable.java 100.00% <ø> (ø) 5.00 <0.00> (ø)
...trategy/triplea/attachments/TriggerAttachment.java 61.25% <ø> (ø) 261.00 <0.00> (ø)
.../java/games/strategy/triplea/delegate/Matches.java 43.69% <0.00%> (+0.10%) 361.00% <0.00%> (+1.00%)
.../src/main/java/games/strategy/net/nio/Decoder.java 67.24% <0.00%> (+1.72%) 12.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b948966...ccffaf3. Read the comment docs.

@DanVanAtta DanVanAtta merged commit b9b5da7 into master Sep 15, 2020
@DanVanAtta DanVanAtta deleted the document-ttatch-hack branch September 15, 2020 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant