-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: highlight search matches and search result score #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of niggles then LGTM
You should try this out if you haven't to see if you like the way it looks, I'm not sure how it will be with colorschemes other than my own. We could also set our own highlight groups for it and allow configuration of that. |
yeah, its a bit wierd on my theme. Moremsg is blue. I would like to move the colours to config, but we also need sensible defaults. What about using the colours for the notify messages? |
or the git colours git = {
add = "#4197a4", -- high score
change = "#506d9c", -- mid score
delete = "#c47981", -- low score
ignore = "#8990b3" --already mapped
}, |
b11abea
to
4e58870
Compare
I think health messages is the move. Those should usually be the same colors, but I've seen a lot of variation in git colors Edit: are health messages default highlights? They're not defined for me even on default colorscheme. |
4e58870
to
47e0164
Compare
is a search that should bring back all score options i will test this when i get home |
47e0164
to
64f45d0
Compare
64f45d0
to
25fb290
Compare
another great contribution, thanks! |
No description provided.