Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dvorak support #88

Merged
merged 4 commits into from
Mar 29, 2024
Merged

feat: dvorak support #88

merged 4 commits into from
Mar 29, 2024

Conversation

tariks
Copy link
Contributor

@tariks tariks commented Mar 29, 2024

Untested Dvorak support.

Note: Dvorak has punctuation at some useful keymap positions.
Note: Dvorak best layout.
Note: Viva la Dvoración.

@tris203
Copy link
Owner

tris203 commented Mar 29, 2024

Thanks so much for your contribution @tariks

I will try and review this. Did you want to add your name to the keyboard contributors in README?

@tris203 tris203 self-requested a review March 29, 2024 09:55
@tris203 tris203 changed the title feature/dvorak feat: dvorak support Mar 29, 2024
Copy link
Collaborator

@willothy willothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a dvorak user so can't verify the Dvorak layout, but looks good to me!

@tris203
Copy link
Owner

tris203 commented Mar 29, 2024

Looks good to me too. Just the documentation changes in README to show support and add @tariks to the contributors if he wants to be there

@tariks
Copy link
Contributor Author

tariks commented Mar 29, 2024

Sure, add me to the readme. Thank you :)

No issues encountered during personal use. Scores make sense for the layout. Great plugin

@tris203
Copy link
Owner

tris203 commented Mar 29, 2024

You can do it yourself @tariks

The README in In the repo. If not I'll do it shortly

Copy link
Owner

@tris203 tris203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

lua/hawtkeys/keyboards/dvorak.lua Outdated Show resolved Hide resolved
@tris203 tris203 merged commit e1b40ff into tris203:main Mar 29, 2024
5 checks passed
@tris203
Copy link
Owner

tris203 commented Mar 29, 2024

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants