Add storage configurations #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdamodaran
approved these changes
Oct 25, 2023
| return cli.Exit(err, 1) | ||
| } | ||
|
|
||
| fmt.Println(string(secret)) |
There was a problem hiding this comment.
Printing the secret was kind of the point since this is in the CLI, this code won't be called from the service and it's more of a debug thing that I wrote to quickly test if the secret manager client was working.
There was a problem hiding this comment.
got it - I had figured you added the print statement to test the functionality but may have forgotten to remove it - thanks for confirming!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds configuration for the certificate storage options (local file storage and google secret manager).