Store password endpoint #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeziel
commented
Oct 26, 2023
pdamodaran
approved these changes
Oct 26, 2023
| require.NoError(err, "could not store certificate password") | ||
| }) | ||
|
|
||
| s.Run("MissingPassword", func() { |
There was a problem hiding this comment.
how about also adding a missing ID check?
There was a problem hiding this comment.
It's hard to test that on the server side since the ID is part of the URL and it would be a 404, however I've added a client test to ensure that the client catches that case, thanks for the suggestion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an endpoint to store a pcks12 password from a POST request using the server's configured store mechanism.