Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formal Node Configuration #2

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Formal Node Configuration #2

merged 2 commits into from
Feb 3, 2024

Conversation

bbengfort
Copy link
Collaborator

@bbengfort bbengfort commented Feb 2, 2024 •
edited
Loading

Scope of changes

Adds the node configuration mechanism and self-documenting CLI command.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

This PR will be merged without review.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have recompiled and included new protocol buffers to reflect changes I made
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

@bbengfort bbengfort merged commit d8ca4b1 into main Feb 3, 2024
4 checks passed
@bbengfort bbengfort deleted the config branch February 3, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bbengfort