Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Email Tests #250

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Live Email Tests #250

merged 2 commits into from
Dec 5, 2024

Conversation

bbengfort
Copy link
Collaborator

@bbengfort bbengfort commented Dec 5, 2024

Scope of changes

This PR makes it easy to test live emails by having them send through SendGrid. To do this, copy the .env.template in the pkg/emails directory to pkg/emails/.env and update the .env file with your email and SendGrid API key.

$ cp pkg/emails/.env.template pkg/emails/.env

(or I can send my .env to you via whisper).

Then you can run the tests with:

$ go test -v -run ^TestLiveEmails$ ./pkg/emails/

Check your email, they should be delivered!

Please note that you may want to change TEST_LIVE_EMAILS=0 when you're done testing so you don't get spammed with a bunch of emails while running tests in Envoy.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have added new test fixtures as needed to support added tests
  • I have added or updated the documentation
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • To the best of my ability, I believe that this PR represents a good solution to the specified problem and that it should be merged into the main code base.

Copy link
Collaborator

@daniellemaxwell daniellemaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it possible to view the emails now! Nice job.

Signed-off-by: Danielle <danielle@rotational.io>
@daniellemaxwell daniellemaxwell merged commit a6e9318 into main Dec 5, 2024
4 checks passed
@daniellemaxwell daniellemaxwell deleted the sc-28578 branch December 5, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants