Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub and YouTube links, update README #251

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Add GitHub and YouTube links, update README #251

merged 4 commits into from
Dec 6, 2024

Conversation

daniellemaxwell
Copy link
Collaborator

@daniellemaxwell daniellemaxwell commented Dec 6, 2024 •
edited
Loading

Scope of changes

This PR adds links to the Envoy repo and TRISA YouTube channel in the navbar. It also updates the README by adding details on the implementation options available for Envoy along with support information.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

https://tinyurl.com/25uv4hz3

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have added new test fixtures as needed to support added tests
  • I have added or updated the documentation
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • To the best of my ability, I believe that this PR represents a good solution to the specified problem and that it should be merged into the main code base.

daniellemaxwell
daniellemaxwell commented Dec 6, 2024
View reviewed changes
README.md
## Envoy Implementation Options

| Open Source | One-Time Setup | Managed Service |
Copy link
Collaborator Author

@daniellemaxwell daniellemaxwell Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This site was used to generate the markdown tables.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use that one too :-)

bbengfort
bbengfort approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those links!

README.md
## Envoy Implementation Options

| Open Source | One-Time Setup | Managed Service |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use that one too :-)

@bbengfort bbengfort merged commit 25c8c18 into main Dec 6, 2024
4 checks passed
@bbengfort bbengfort deleted the sc-27735/links branch December 6, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbengfort bbengfort bbengfort approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellemaxwell @bbengfort