Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hx-post request to send Sunrise form and handle data transformation #252

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

daniellemaxwell
Copy link
Collaborator

@daniellemaxwell daniellemaxwell commented Dec 9, 2024

Scope of changes

This PR adds the route to send the Sunrise message to the hx-post attribute, transforms the data sent in the request, and adds a crypto address field for the originator.

The response currently returns an error, but this is related to SC-28577.

Type of change

  • bug fix
  • new feature
  • documentation
  • other (describe)

Acceptance criteria

Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have updated the dependencies list
  • I have added new test fixtures as needed to support added tests
  • I have added or updated the documentation
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • To the best of my ability, I believe that this PR represents a good solution to the specified problem and that it should be merged into the main code base.

@daniellemaxwell daniellemaxwell removed the request for review from bbengfort December 9, 2024 17:25
Copy link
Collaborator

@pdeziel pdeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, unfortunate that we have to do the key prefix stripping but I don't see any issues with the code as is.

@daniellemaxwell daniellemaxwell merged commit ddfa760 into main Dec 10, 2024
4 checks passed
@daniellemaxwell daniellemaxwell deleted the sc-28149 branch December 10, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants