Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rVASP IVMS 101 #100

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Update rVASP IVMS 101 #100

merged 1 commit into from
Jun 21, 2022

Conversation

bbengfort
Copy link
Collaborator

This PR updates the rVASP LegalPerson and NaturalPerson records for the rVASP business records and their "account holders" to allow it to match more closely with correct/expected IVMS101.

@pdeziel is changing just these fixture files sufficient to have them be included in the next migration?

@bbengfort bbengfort requested a review from pdeziel June 21, 2022 22:20
pdeziel
pdeziel approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@pdeziel pdeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and yes this should be all we need to do assuming the images get built and pushed correctly in the CI when we do the next tag.

@bbengfort bbengfort merged commit c2148b2 into main Jun 21, 2022
@bbengfort bbengfort deleted the sc-6405/rvasp-ivms branch June 21, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeziel pdeziel pdeziel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbengfort @pdeziel