sc-7148 fix expired transaction issue #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeziel
commented
Jul 13, 2022
| return nil, status.Errorf(codes.FailedPrecondition, "TRISA protocol error: could not parse ReplyNotAfter timestamp in pending message: %s", err) | ||
| } | ||
|
|
||
| xfer.SetState(pb.TransactionState_ACCEPTED) |
There was a problem hiding this comment.
This was the offending code, at this point we haven't responded to the original Transfer RPC so creating a new transfer back to the beneficiary violates the ordering a bit. The change is to move the new transfer to the async handler instead.
pdeziel
commented
Jul 13, 2022
|
|
||
| xfer.SetState(pb.TransactionState_ACCEPTED) | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This is where the code was copied to to fix the ordering issue.
DanielSollis
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue discovered during the last deployment where async transactions were expiring. The cause is a bit complicated, but it boils down to two go routines trying to modify the transaction record at the same time and overwriting each other.
After looking at this a bit I realized the root of the problem is the originator code (in
rvasp.go) creating a new transfer request before responding to the beneficiary. This fix isolates things a bit more by creating a few more transaction states and having the originator respond asynchronously using the async routine rather than immediately.