Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC-7278 fix identity validation #106

Merged
merged 1 commit into from
Jul 19, 2022
Merged

SC-7278 fix identity validation #106

merged 1 commit into from
Jul 19, 2022

Conversation

pdeziel
Copy link
Collaborator

@pdeziel pdeziel commented Jul 18, 2022

This fixes the identity payload validation so that the beneficiary fields are only checked on the "repair" policies, and also fixes the problem where a nil response was being returned to gRPC.

@pdeziel pdeziel requested a review from bbengfort July 18, 2022 22:55
bbengfort
bbengfort approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking those issues down @pdeziel! Are we ready to attempt a smoke test again?

@pdeziel
Copy link
Collaborator Author

pdeziel commented Jul 19, 2022

Thanks for tracking those issues down @pdeziel! Are we ready to attempt a smoke test again?

I think so, I tested against Charlie with the partial payload before and after this change and it seems to have fixed the issue.

@pdeziel pdeziel merged commit 47ca880 into main Jul 19, 2022
@pdeziel pdeziel deleted the sc-7278 branch July 19, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbengfort bbengfort bbengfort approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdeziel @bbengfort