bug fix for natural person validation #117
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,121 +1,121 @@ | ||
| -----BEGIN CERTIFICATE----- | ||
| MIIF8DCCA9igAwIBAgICB5kwDQYJKoZIhvcNAQELBQAwgZQxDDAKBgNVBAYTA1VT | ||
| QTELMAkGA1UECBMCTUQxEzARBgNVBAcTClF1ZWVuc3Rvd24xFjAUBgNVBAkTDTIx | ||
| NSBBbHlubiBXYXkxDjAMBgNVBBETBTIxNjU4MSYwDAYDVQQKEwVUUklTQTAWBgNV | ||
| BAoTD1JvdGF0aW9uYWwgTGFiczESMBAGA1UEAxMJdHJpc2EuZGV2MB4XDTIzMDIx | ||
| NTIwMTE0OFoXDTIzMDgxNTE5MTE0OFowajEMMAoGA1UEBhMDVVNBMQswCQYDVQQI | ||
| EwJNRDETMBEGA1UEBxMKUXVlZW5zdG93bjEJMAcGA1UECRMAMQkwBwYDVQQREwAx | ||
| EjAQBgNVBAoTCXRyaXNhLmRldjEOMAwGA1UEAxMFYWxpY2UwggIiMA0GCSqGSIb3 | ||
| DQEBAQUAA4ICDwAwggIKAoICAQDJgaPxN7LOfEEDSWCAhVdn9VLaHhinmEO3iw5L | ||
| lPW/MVH6/nsCK0FZ0KYQX2LNNCPDbgF231Wo5JkXT0CdHVc9Q201SEhizRPfV/gJ | ||
| LW3tRke5FLZfBMg0hVi+696vLeCBW2bHiUsVOfq7pskiOZX6W0zfYDACYhz2vvvX | ||
| pGLzqUWkFnGaTTMz0RHq7os6Qdb0OhSanCVm211S8VqU1NKytmNLjcSuTCATYyQy | ||
| jVAe1u644y7FTn/3KMpvQZo6iYXFRtaLFP7nSFLG/iQCKFRAA6K3e5xMIsyi0jZ1 | ||
| fWFAZrmbOuWqAdRo/IDhOi4IlLBJILvdVr9uEC9zGcfvmxBetwwPHJ7qmn9LLX6L | ||
| qiZLAfO4kbvNnXls+E1VepCVZlGhDtgqe3Mj2q3hcRinSZ9qojP+IG8L03jHEErL | ||
| Ws5m6dT7bLEQBIQPEFgrq2qKKIJl4pxujQf616Xk7VgD98E4uSF/DLhbzHsb9uis | ||
| SLerQzScZN27k9GrrasPGGyEyb6q7HNovyXVYCdrzo6nfU/NzJA5vdzJC4NdJzO7 | ||
| aa68sI0ncinWuDib/iUqOYcHLmlgNnOcg6WX2wUmSkIZ4MD4ulbndvfN27b75e8i | ||
| DCE1lpuNtIX0TG85hualZiRPzdxn6tIVqFFUfg3/lWgOQIWZxbbCzK9Dbg9DY16d | ||
| anWPJQIDAQABo3UwczAOBgNVHQ8BAf8EBAMCB4AwHQYDVR0lBBYwFAYIKwYBBQUH | ||
| AwIGCCsGAQUFBwMBMA8GA1UdDgQIBAYBAgMEBQYwHwYDVR0jBBgwFoAUNvfEnm7O | ||
| CUfj2pKvGvJXNGnzZbUwEAYDVR0RBAkwB4IFYWxpY2UwDQYJKoZIhvcNAQELBQAD | ||
| ggIBAMRH4L7jxIhbWZyue8cs8G/3xdm5arMh2vcDy0MoD1uTJ7bejD/ghfHyyKh3 | ||
| RHpmQDT7LbEZG3SkZHfMfZqgRPcPn1Gufj7m3y7yKmbqgcfW57AIqHPif8smfMJ6 | ||
| c1WdOeCNFPtsyACor/xA2Gy/FbT34ATZPor3opGtIaW67QzmvOzjXhq5vMseGi1k | ||
| Zjz7P9Rk5/+CWc1WVw1Jrlm9zPLsKusIDxvadVAZb9iq3yg8hi2vzIdTTzbRBunX | ||
| G5XAM0YQ+3eTKjZRMn4zy/8MyH0T0ZFqTJlRD1OoJSx4L/nEu5RPuavliFIHdZ/a | ||
| KciaJuLZxvBq8LAByD85IHU1PVolq2Hp2KLR0LkaePeB/LqI0XGNT+ihrNpdqDBG | ||
| Bw6mOtPzrYsuLt0nXxu+xd103Xlde7Npx7OscXSrV+sZihTHCULFr43N8UuYW4q6 | ||
| arJv2naYNoajby/WOZYvE2PynlLa2LFXCjp69rtoAuSoncCeO2YVT5CLdf4hHnKQ | ||
| FsPQfVXVEfJ65DAMPksCpqOZAVGlDFEcjbn8Z/MUXwLYjDcDVV9WAEcaG0IXgMR3 | ||
| fIYbD47EfMD1fQG+iBu2/dP5EdOfzCcxThUME20phLNiyW1s2nF5ixL/QS4D406e | ||
| An9nIaTyZI/rrZ6bRsaXkMaadu+r45eD4d2JRzSwrMLDber4 | ||
| -----END CERTIFICATE----- | ||
| -----BEGIN CERTIFICATE----- | ||
| MIIGHTCCBAWgAwIBAgICB5YwDQYJKoZIhvcNAQELBQAwgZQxDDAKBgNVBAYTA1VT | ||
| QTELMAkGA1UECBMCTUQxEzARBgNVBAcTClF1ZWVuc3Rvd24xFjAUBgNVBAkTDTIx | ||
| NSBBbHlubiBXYXkxDjAMBgNVBBETBTIxNjU4MSYwDAYDVQQKEwVUUklTQTAWBgNV | ||
| BAoTD1JvdGF0aW9uYWwgTGFiczESMBAGA1UEAxMJdHJpc2EuZGV2MB4XDTIyMDkx | ||
| NTE1NDcwMVoXDTMyMDkxNTE1NDcwMVowgZQxDDAKBgNVBAYTA1VTQTELMAkGA1UE | ||
| CBMCTUQxEzARBgNVBAcTClF1ZWVuc3Rvd24xFjAUBgNVBAkTDTIxNSBBbHlubiBX | ||
| YXkxDjAMBgNVBBETBTIxNjU4MSYwDAYDVQQKEwVUUklTQTAWBgNVBAoTD1JvdGF0 | ||
| aW9uYWwgTGFiczESMBAGA1UEAxMJdHJpc2EuZGV2MIICIjANBgkqhkiG9w0BAQEF | ||
| AAOCAg8AMIICCgKCAgEAzAYZzfhl2RDyJt7qqeBSrsp2hj3zE09o/VIqqShLFD4v | ||
| D8AXsR5uRJ7jZWBVfcK+7Z5k4B4xdzswlFEiW8g33/43FIeH52/I9RnI0CjsQPPS | ||
| qO37TdMVg4Wlw89jY8EE88+PrnCj+mBRdHHCEMMxhvcpg0SHzVTaiDjfAec9bDzN | ||
| wPd+oZf/6y2xyAclmA8NF9VW9bAOXT1FKtOxHDi2PK8dRwb+yHs1SXJI+ujhZylS | ||
| DO4yFRnHwcCEtpyV0zOmaeanD37/24eEYxLnU6iUmEhRgCubFDKdet9Y9sMlyNvR | ||
| em5WE+1jJsJQtsI2qNRMJcr8PXXNcuZh74bmqVYvrN3CImgrez9Q405N01r+9eSM | ||
| HGo5HGIU3zu54vkAztRJff7cyKZtLdI3rwy80+zgbc1eBQJYkIhNQ4DKUnnK6dfv | ||
| SShKNZBUws6dQGfRkO7a9p9He/d3Q6L64xh6pBHdIHZG8hc/JRpiTVKZVs5jGed2 | ||
| vbBR+k9EwRON/mOMhN9RsVL2ygXL/Za6Q1Bc0ssLacQy5l0Lg9UG9QnTgWCxLxN6 | ||
| t/MylAkDlD2sR9+3Ncn306A72tUDpd6dWK16KzZSYA8tiH953gnrIjYkZoKagN+z | ||
| r9ICILwJ8zeyJjAnkVRrcGHcM1S7rPTG9pozvE2cP8bAbxNmnbjSiGuEm5XEL1MC | ||
| AwEAAaN3MHUwDgYDVR0PAQH/BAQDAgKEMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggr | ||
| BgEFBQcDATAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBQ298Sebs4JR+Pakq8a | ||
| 8lc0afNltTAUBgNVHREEDTALggl0cmlzYS5kZXYwDQYJKoZIhvcNAQELBQADggIB | ||
| AB0ffH2s/TBeGamNTb+kixTxhvBOSOt//hgxGinCvk9hh/ldgDcH7LLryP/dvFwG | ||
| 5MzKS8kZWvkxgHj3IsBoFVw+kG2QfWYtOIJxqKBJWwf755KEpmfzIJF23z+U+zP4 | ||
| qVD22NV2Z+4JAlO2t9V5WwginxkohsHKCxn5lv76yIgKrFNJJo6v5X06g/KSK0My | ||
| 0BJrp/v4JltwE9j++cVuP7Uo0vwXlYzhphhK2GAQGEqWg2bEbGNfx/QE5ajFh4ZH | ||
| jcNJcOvMGyTQGNFHWqDFhTzBpxunzaLDu6M6dtgxOkS+Jy7tf/X3eJwgWxq+U+9u | ||
| w8V/5jKJ4Mi5ojMvTj74SOzpwDaWQv96j8etHYfYgi+ObYK9unKvC8VYoGo0Tl8S | ||
| PBzVU8fMBIpc3auD9wh5JUNVbUtv+qD4jmy3fOHLTEMHDxxo5qP7mu84R0OX8RBW | ||
| +iFPzPdANUYwolbjp9agrE7iz+dQVF875ZR/jiRYpWAZ/FPWRdg+M8BHbRfmlGTU | ||
| r5lirfDVcaqE+j6j8BEzPjUHtCL/OO7A7VxGosmqI1lTJxAwhegPeZHSIubl3gi6 | ||
| DxgzswLa0yQRyD5YJj8oA1t9bDiT09x/DlGJBlXVdfFiaOp9Uy3Fq9vIm//pbq0E | ||
| lrbyuTEXHPRwp+x0gxmQm3Mj9EcRG7FNQCdUd8OcdrRO | ||
| -----END CERTIFICATE----- | ||
| -----BEGIN PRIVATE KEY----- | ||
| MIIJQwIBADANBgkqhkiG9w0BAQEFAASCCS0wggkpAgEAAoICAQDJgaPxN7LOfEED | ||
| SWCAhVdn9VLaHhinmEO3iw5LlPW/MVH6/nsCK0FZ0KYQX2LNNCPDbgF231Wo5JkX | ||
| T0CdHVc9Q201SEhizRPfV/gJLW3tRke5FLZfBMg0hVi+696vLeCBW2bHiUsVOfq7 | ||
| pskiOZX6W0zfYDACYhz2vvvXpGLzqUWkFnGaTTMz0RHq7os6Qdb0OhSanCVm211S | ||
| 8VqU1NKytmNLjcSuTCATYyQyjVAe1u644y7FTn/3KMpvQZo6iYXFRtaLFP7nSFLG | ||
| /iQCKFRAA6K3e5xMIsyi0jZ1fWFAZrmbOuWqAdRo/IDhOi4IlLBJILvdVr9uEC9z | ||
| GcfvmxBetwwPHJ7qmn9LLX6LqiZLAfO4kbvNnXls+E1VepCVZlGhDtgqe3Mj2q3h | ||
| cRinSZ9qojP+IG8L03jHEErLWs5m6dT7bLEQBIQPEFgrq2qKKIJl4pxujQf616Xk | ||
| 7VgD98E4uSF/DLhbzHsb9uisSLerQzScZN27k9GrrasPGGyEyb6q7HNovyXVYCdr | ||
| zo6nfU/NzJA5vdzJC4NdJzO7aa68sI0ncinWuDib/iUqOYcHLmlgNnOcg6WX2wUm | ||
| SkIZ4MD4ulbndvfN27b75e8iDCE1lpuNtIX0TG85hualZiRPzdxn6tIVqFFUfg3/ | ||
| lWgOQIWZxbbCzK9Dbg9DY16danWPJQIDAQABAoICAASlV4lNNnMqTDluLKpp6Jz9 | ||
| +/4JaZobmZwWuaqmcZAJ7BD0YxOmuaf/doS0HkwK4rQzyhbaiVgOhTUTX7L/pS5F | ||
| arQqyXh1r/qbRZ24jWtGDotG3fmM26zSUjx8pbK2RRHWcKUzFicUIiLHcqW2XC3c | ||
| gwY3aoPzjSVnO9k58goaIf/pgI8FLqQIMviOrWkXcYRJ/oWeCgK4Fgu+gs8hpQX3 | ||
| zIxGZX17RdYMmB4OQgWkAPcETeTArZSePSSZh5vH5eypeHLWdhYRBc+OtnfSRDcB | ||
| nnPKhsz+lGdAn37P+DkK5Uad8gOcbTBKehI3TC5odzQIbCxrPpikCOQHeSOeGJ97 | ||
| 6GWWnYePIoFdspnHJioCa6bkDFaWaoeEu+Tah0ewSOf+PuxCN61h4wfp6crR5qND | ||
| yU8L/fadhifv94glGJeas/LJSpLVbxul1DlCC4XIbhXgM7SBDzCPGjf10eaOYMZB | ||
| 3MWaaurz03C0moOiw0BfOgqMp3HnUZCa1GACfbm8I3AWWfQ5dqgEA8708xPpgXAa | ||
| i/lRyJkfij0IhJfX8rrD2ST9Fe9fAxVBMmkqGPmgBKyWht0e6bP99zGbC9cL6Nhw | ||
| t0iiTyN1B0h4gTc+aWGaNNECGRWpvsxHFnRvAi+AHE2A55SLbfQ0VWosUuNOdu+3 | ||
| 04XDSJb3IKcwlpGlZSFhAoIBAQDQ5SUo+vJHI9jRrdpuHYtjQK0XVn6NK6ME68XM | ||
| 9pY5QAYN+2JbH1NQnAiGYNqTbA1xauAWWWW17cwtanTU0AkO6Xiklz4NO0C9vmTz | ||
| Y1Ie/iUyjozrG8jFPZRiuAT9vHJD7sJNSRl7WahHB8IM8hT9BqNHD2QSlAdDVJgR | ||
| MXeaC/YdC1vC0xJ331QRzdkNEG1rMPeteleJ2nGK4koW3Tsj9fqE4A2EYlP/sO3L | ||
| ihXcvvOie9nHZBccPZX1hTB035yeH3d0apk79aHzrpOU2txAXtGgdCe7UtjpDBXI | ||
| wOaKEqvYJaGrnls/GDWPpILf23RqnNvT6hFutVA4PZK9z1T5AoIBAQD28fguaSZ3 | ||
| Q6R5TPgYomOxZLfVVnYSp+8CjzTLkSZjA6plLQDcD29dGi7TDGM2YJJ8wom+AujJ | ||
| NVe1uuBUDtn+PGmqj2EgzZ7lAUea7KYAY9dB1H8RSUYvE+5E2IUdCJB5FwrR+6Ym | ||
| tUTrI8wHcFgDsf4U09ac8m5NXp/h1TBzGYIwJAOYuNfNX3piGvapn4GXEQG5UIAN | ||
| tmCN+vmeSNRMu6Ec6MxC1r6LIgELh2jDozSiStaYiYY5EoWd2ouaUiMWrByNhJrC | ||
| MUGVzLaDXhDkpu1lNT/N2yUrB4odXj4C7pCqS0wAV4vrKN6RMIv+3Z60LXSkrRhK | ||
| +q4ApPvFbFKNAoIBAQDIqXVaukSFRc//Cwvp/wNoYjZjVrjWDvbXwUwOqUiA0hl+ | ||
| 0N4YPi0gH+Kogt00A/Wd31ZG4bUsX7NkZQC5dOVep7M2F/qJZ0O3gO8kRWIbV3KP | ||
| 8BM5vUTNA2xIsBBLVPxGeVG4P+H0dZmKMc+b8+dpbzjlB8nPdtbLPLWevm/vUFIo | ||
| cELDEVKKR8NQHvbC7+bLswwYXo88YtPy35DgCb/HuX/eqAMUCgg6c9DZVlnN5LfQ | ||
| ezwlpuX0QMyOPlTfz/V4hy2ObN+pkzjxBd/Ke7pbMzoW8b1A2kJ3Cx7Z60MJmwnr | ||
| 5ao5WzK3lx/MTfFR7FMWHnukQxJf0FewzqTpJAKxAoIBAQCA+NcZxikk2Nspzx00 | ||
| IHvYxjWM4l9AVxzpRUnZl7FovR1dQifUxuruwSH7b9jRKZbYOfIenv5dN9LbQwKu | ||
| ZCNOONcnEUM1Eq8OA6EWNMpuIbbm1siWiqJxLAOhSUQcacCqvXIVQU0BomKgPE3v | ||
| BKmzJF8DGbBYv/UDy4vNMr7fHk90PRrzxHZQ+LC+VD7HUFsqPuObmYOHpdy/ynhc | ||
| RsU6XjRDGQK1VdqmZ9gL4WjB5Jc0u8lgWVMUs6u9ScrnikZxLOqsrrj0+yy5w/T+ | ||
| nz5LbTNHTIxKQ04iLwnfVL0mYtqDVlgXRaH565pyUdyL+8tLZwIoj47EejAuffxQ | ||
| m8ZxAoIBAGEORIY34djS1v0Y+mGAt7Dkv4mznqzKoKkrJZuBqYYDokQkyb5kjX/4 | ||
| Vff9n80LjuuYrVIGNw48AMCsM91Unx3+U148sUKHUJu6brTAR+ajobgJWwRIeJd5 | ||
| b/IieH6pwFs+9hVKf31J4wK3pM6BhZg0rGB/BS2/0OV1d5/ekHMwYLVgFlb7C/PX | ||
| Y9PvLLnsb5eclOeQ437PKPi2RIAgIWnzgo894nR6pv5bLXc/yE0VbPBaW+rAVLV3 | ||
| ijEkeUGsIwt+yBccErGy7y9oSx3SgqbS7B7L750LWImp9xDqnPHRmkdpcb2ucxuT | ||
| 1c7WwZcUVdV0NCFQ7k++KycaEufvf6k= | ||
| -----END PRIVATE KEY----- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -222,9 +222,11 @@ func validateIdentityPayload(identity *ivms101.IdentityPayload, requireBeneficia | |
| } | ||
|
|
||
| // Validate the beneficiary person | ||
| if naturalPerson := identity.Beneficiary.BeneficiaryPersons[0].GetNaturalPerson(); naturalPerson != nil { | ||
| if err = naturalPerson.Validate(); err != nil { | ||
| log.Warn().Err(err).Msg("beneficiary person validation error") | ||
| return protocol.Errorf(protocol.ValidationError, "beneficiary person validation error: %s", err) | ||
| } | ||
|
There was a problem hiding this comment. I think we need a default case to handle the case where the beneficiary person is nil (or something that happens to fit the See this example, if a nil object is type checked then the default case is triggered: https://go.dev/play/p/aHIX6AOtfJz |
||
| } | ||
|
|
||
| // Check that the account number is present | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If natural person is nil do we also want to consider that an error? In other words is the beneficiary person required for a valid beneficiary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue here is that Krupa's identity had a legal person under
beneficiary_personsand not a natural person, which if I'm correct is entirely valid IVMS101There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, here's what I propose. Let's make it a switch statement and check for either
NaturalPersonorLegalPerson. In both of those cases validate the entity, otherwise return a validation error. That should correspond better to IVMS101. We should probably do the same forBeneficiaryVASPon line 250 while we're at it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea, I implemented the changes, that should fix the issue