Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC-14000 Add Identity Payload Validation Tests #121

Merged
merged 5 commits into from
Feb 24, 2023
Merged

SC-14000 Add Identity Payload Validation Tests #121

merged 5 commits into from
Feb 24, 2023

Conversation

DanielSollis
Copy link
Contributor

Adds tests for the transfer.go ValidateIdentityPayload method (and exports it so it can be tested).

@DanielSollis DanielSollis requested a review from pdeziel February 23, 2023 18:59
pdeziel
pdeziel approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@pdeziel pdeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding the tests!

pkg/rvasp/transfer.go Outdated Show resolved Hide resolved
@pdeziel
Update pkg/rvasp/transfer.go
ee8ccdb 
Co-authored-by: Patrick Deziel <42919891+pdeziel@users.noreply.github.com>
@DanielSollis DanielSollis merged commit 587e1f7 into main Feb 24, 2023
@DanielSollis DanielSollis deleted the sc-14000 branch February 24, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeziel pdeziel pdeziel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielSollis @pdeziel