Log network activity in rVASP #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like the tests are failing - I will need to look into these. |
pdeziel
reviewed
Aug 28, 2023
| @@ -40,6 +41,8 @@ func (s *Server) fetchSigningKey(peer *peers.Peer) (key *rsa.PublicKey, err erro | |||
| } | |||
|
|
|||
| if peer.SigningKey() == nil { | |||
| // send key exchange activity to network activity handler | |||
| activity.KeyExchange().Add() | |||
There was a problem hiding this comment.
Nice! We will also need to add a call to activity.Start() when we're starting the rVASP server, (in New() of rvasp.go).
pdeziel
approved these changes
Sep 1, 2023
pkg/rvasp/rvasp.go
Outdated
| @@ -88,6 +89,7 @@ func New(conf *config.Config) (s *Server, err error) { | |||
| s.peers.Connect(grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
| } | |||
| s.updates = NewUpdateManager() | |||
| activity.Start(conf.Activity) | |||
There was a problem hiding this comment.
Doesn't this return an error? If so, it should be handled like the other service errors here so that we're not confused if there's bad configuration and it doesn't start.
There was a problem hiding this comment.
good point - I have made the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves SC-20306 that asked to log network activity in rVASP. This includes calls to Search, Lookup, and KeyExchanage. This is currently pulling from the main branch of the directory repo.