sc-5117 Add goreleaser #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbengfort
reviewed
Jun 10, 2022
.github/workflows/release.yml
Outdated
| env: | ||
| GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} | ||
| GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }} | ||
| HOMEBREW_TAP_GITHUB_TOKEN: ${{secrets.HOMEBREW_TAP_GITHUB_TOKEN}} |
There was a problem hiding this comment.
I don't think we need to get homebrew involved for the rvasp CLI at this stage so you can probably remove this secret.
bbengfort
approved these changes
Jun 10, 2022
.github/workflows/release.yml
Outdated
| args: release --rm-dist | ||
| env: | ||
| GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} | ||
| GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }} |
There was a problem hiding this comment.
Did you configure the GitHub secrets in settings with everything needed here or does that still have to be done?
| - -v | ||
|
|
||
| # Custom ldflags templates. | ||
| ldflags: -s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{.Date}} |
There was a problem hiding this comment.
Does the cmd/rvasp package have these variables? I think we have to set them in pkg.version?
| # Footer for the release body. | ||
| footer: | | ||
| ### About | ||
| The rVASP tool is a binary command line application that is used to run and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the goreleaser GitHub action to publish releases of the rVASP program.