Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rVASP Test Script #97

Merged
merged 1 commit into from
Jun 16, 2022
Merged

rVASP Test Script #97

merged 1 commit into from
Jun 16, 2022

Conversation

bbengfort
Copy link
Collaborator

This script executes several rVASP commands in a row in meaningful combinations between Alice and Bob as a quick check to ensure the rVASPs are up and running.

@bbengfort bbengfort requested a review from pdeziel June 16, 2022 00:06
pdeziel
pdeziel approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@pdeziel pdeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these, we will probably need to find a way to verify the responses but outlining these integration test cases is a good starting point.

@bbengfort bbengfort merged commit 86f2a77 into main Jun 16, 2022
@bbengfort bbengfort deleted the rvasp-test branch June 16, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeziel pdeziel pdeziel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbengfort @pdeziel