Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-6368 Add containers action #98

Merged
merged 1 commit into from
Jun 20, 2022
Merged

sc-6368 Add containers action #98

merged 1 commit into from
Jun 20, 2022

Conversation

pdeziel
Copy link
Collaborator

@pdeziel pdeziel commented Jun 17, 2022

This adds a containers build and push action so that images are automatically built with on PRs and pushed on tags.

@pdeziel pdeziel requested a review from bbengfort June 17, 2022 19:15
Copy link
Collaborator

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, hopefully, this makes the build process a bit easier on us when we're redeploying and this Action will go nicely with goreleaser! Can't wait to test it all out on our next version tag!

Were you able to set the DOCKERHUB_USERNAME, DOCKERHUB_TOKEN, and GCR_JSON_KEY GitHub secrets in the repo?

@pdeziel pdeziel merged commit 84e86dd into main Jun 20, 2022
@pdeziel pdeziel deleted the sc-6368 branch June 20, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants