New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract some methods from parse_match_pattern #254

Merged

trishume merged 1 commit into master from extract-methods-from-parse-match-pattern

Jul 24, 2019

Collaborator

robinst commented Jul 24, 2019

Makes it a bit less long and enables reuse later.


          Extract some methods from parse_match_pattern

00da5ff

Makes it a bit less long and enables reuse later.

robinst commented

View reviewed changes

src/parsing/yaml_load.rs

@@ @@ -292,69 +292,22 @@ impl SyntaxDefinition { @@
                       }
                   }
-                  fn resolve_variables(raw_regex: &str, state: &ParserState) -> String {

Collaborator Author

robinst Jul 24, 2019

These two were just moved further down to make it a bit more consistent (the reading order of methods in the file is top down).

keith-hall approved these changes

View reviewed changes

trishume approved these changes

View reviewed changes

trishume merged commit ac851b8 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet