fix panic when highlighter cache is empty #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you for taking a look at this, @keith-hall! |
trishume
approved these changes
Sep 4, 2019
|
It would be fantastic to get a patch release with this bugfix, as it prevents us from updating (only if you find the time, I definitely don't want to bother you with downstream problems 😃) |
|
@sharkdp Done, released as v3.3.0 |
|
@trishume Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a panic which occurs when highlighting a JSON file using a recent version of
JSON.sublime-syntaxfrom the sublimehq/Packages repo. This bug was originally discovered at sharkdp/bat#644 - the steps for reproducing the panic are there.Note, I haven't added a unit test for this yet, and am not sure when I will get chance to work on one... If someone else wants to take it on, please do.