Upgrade Swift 5 & fix warnings #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Swift version to 5 - XCode automaticly created IDEWorkspaceChecks.plist after update it - Delete SWIFT_SWIFT3_OBJC_INFERENCE from project.pbxproj
- Fix `hashValue` to `hasher(into: )` in MappableExtensionsTests.swift - Fix warnings related to `try?` declaration in ImmutableTests, MapContextTests, PerformanceTests
|
Travis fails because of invalid options PTAL @tristanhimmelman 🚀 -> Travis CI invalid options issue |
gcharita
suggested changes
Jan 31, 2020
|
🚀 PTAL @gcharita |
|
any update on this? |
|
If you rebase this to get CI passing I will approve and merge |
Merge master to emrcftci/master
emrcftci
added a commit
to emrcftci/ObjectMapper
that referenced
this pull request
May 16, 2020
- Revert accidently created commit from another pull-request -> tristanhimmelman#1081
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Swift version to 5
Fix warnings related to Swift 5
Motivation and Context
We will be compatible with the Swift 5,
We will solve warnings
after this pull-request merge.
What kind of change does this PR introduce?