Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC client generated python files are really old #4984

Closed
omidb opened this issue Oct 15, 2022 · 5 comments
Closed

gRPC client generated python files are really old #4984

omidb opened this issue Oct 15, 2022 · 5 comments
Labels
enhancement New feature or request investigating The developement team is investigating this issue

Comments

@omidb
Copy link

omidb commented Oct 15, 2022

Is your feature request related to a problem? Please describe.
This is a blocking issue for us.
gRPC-generated files are old and incompatible with many other libraries (tested for Python). As has been mentioned here:

Restrict maximum version due to breaking protobuf 4.21.0 changes
(see protocolbuffers/protobuf#10051)
TODO: Update to be compatible with 4.0 release (DLIS-3809)
protobuf>=3.5.0,<3.20
There is memory leak in later Python GRPC (1.43.0 to be specific),
use known working version until the memory leak is resolved in the future
(see grpc/grpc#28513)
grpcio==1.41.0
numpy>=1.19.1
python-rapidjson>=0.9.1

Describe the solution you'd like
We can do two things: Release the client with two different Protoc support: version 3 and version 4. Or we can just increase the version to the latest.

Describe alternatives you've considered
Using HTTP or gRPC but not using the triton-client package which is not ideal as there are many nice optimizations in the package.

@kthui
Copy link
Contributor

kthui commented Oct 17, 2022

Hi @omidb, we have a ticket to increase the protobuf version. I have added your request into the ticket.

@kthui kthui added enhancement New feature or request investigating The developement team is investigating this issue labels Oct 17, 2022
@omidb
Copy link
Author

omidb commented Oct 19, 2022

@kthui thanks

@sataset
Copy link

sataset commented Dec 12, 2022

I was accidentally reporting to old PR regarding this issue.

triton-inference-server/client#109 (comment)

@kthui can you tell why this cannot be implemented straight away?

perf_analyzer is not part of a tritonclient library, thus this requirement is unnecessary.

This dependency requirement should be resolved by restricting version in docker image wich includes perf_analyzer.

@kaancfidan
Copy link

This is also a blocking issue for us, and the supported Python version is 3.8, which is very old right now.

@jbkyang-nvi
Copy link
Contributor

fixed with ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request investigating The developement team is investigating this issue
Development

No branches or pull requests

5 participants