Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove AWS bucket on test failure #7342

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Jun 12, 2024

What does the PR do?

To delete the created AWS bucket on L0_backend_python env sub-test if the server would fail to start.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

N/A

Where should the reviewer start?

N/A

Test plan:

N/A

  • CI Pipeline ID:
    T.B.D.

Caveats:

N/A

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@kthui kthui added the PR: test Adding missing tests or correcting existing test label Jun 12, 2024
@krishung5 krishung5 marked this pull request as ready for review July 8, 2024 21:55
@krishung5 krishung5 requested a review from Tabrizian July 8, 2024 21:55
@krishung5 krishung5 requested a review from mc-nv July 8, 2024 22:01
Copy link
Collaborator

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Hopefully this should relieve the "TooManyBuckets" error from running out of S3 buckets.

@krishung5 krishung5 merged commit e0d80d4 into main Jul 8, 2024
3 checks passed
@krishung5 krishung5 deleted the jacky-py-aws-bucket branch July 8, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: test Adding missing tests or correcting existing test
Development

Successfully merging this pull request may close these issues.

4 participants