feat: Support for request id field in generate API #7392
Conversation
|
Hi Already done? |
|
Hi @GuanLuo request you to review |
|
Hi @shreyas-samsung, Thanks for contributing the PR! Can you also try adding a new test function This test should minimally:
If you run into any issues with this, I can try to help with adding the tests as well. |
|
Hi @rmccorm4 Thank you for the review. I have added the test as per your suggestion. |
| @@ -142,6 +142,49 @@ def test_generate(self): | |||
| self.assertIn("TEXT", data) | |||
| self.assertEqual(text, data["TEXT"]) | |||
|
|
|||
| def test_request_id(self): | |||
There was a problem hiding this comment.
Thanks for adding the test! I will run a pipeline with these changes.
Pipeline ID: 16450437
There was a problem hiding this comment.
Pipeline looks mostly good, and the new unit test passed, however, please update this variable from 15 to 16 to account for the new test added:
Line 665 in e0d80d4
EXPECTED_NUM_TESTS=16
There was a problem hiding this comment.
Thanks. Updated count to 16
There was a problem hiding this comment.
Thanks! Ran a new pipeline 16473896 and it passed 🚀 Once I verify the CLA, this can be merged 👍
|
LGTM |
|
We have accepted your CLA and can merge at the Triton team's discretion. |
There was a problem hiding this comment.
LGTM, thanks for the contribution @shreyas-samsung, we really appreciate it!
rmccorm4
changed the title
What does the PR do?
This PR adds support for request id field in /generate API. This makes it possible to debug and trace any particular request by giving an identifier in request body which gets logged everywhere.
Checklist
Agreement
<commit_type>: <Title>pre-commit install, pre-commit run --all)Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)