Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Triton Docs to New Theme #7891

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Conversation

nv-kmcgill53
Copy link
Contributor

What does the PR do?

#7807

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

#7807

Where should the reviewer start?

Test plan:

N/A

  • CI Pipeline ID:

N/A

Caveats:

N/A

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@nv-kmcgill53 nv-kmcgill53 added PR: docs Documentation only changes cherry-pick labels Dec 18, 2024
import os

import httplib2
import nvidia_sphinx_theme

Check notice

Code scanning / CodeQL

Unused import Note documentation

Import of 'nvidia_sphinx_theme' is not used.
docs/backend_guide/vllm.rst Outdated Show resolved Hide resolved
statiraju
statiraju previously approved these changes Dec 18, 2024
@yinggeh
Copy link
Contributor

yinggeh commented Dec 18, 2024

Is there a pipeline for this change?

@nv-kmcgill53 nv-kmcgill53 force-pushed the kmcgill-cherry-pick-docs branch from 9090e8c to 2b3d40b Compare December 23, 2024 18:43
@statiraju statiraju requested a review from rmccorm4 December 23, 2024 18:55
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to be in sync with what's already live on the docs for the release

@nv-kmcgill53 nv-kmcgill53 merged commit 1efbd53 into r24.12 Dec 23, 2024
3 checks passed
@nv-kmcgill53 nv-kmcgill53 deleted the kmcgill-cherry-pick-docs branch December 23, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR: docs Documentation only changes
Development

Successfully merging this pull request may close these issues.

6 participants